BLD: run pytest on wheels and sdist #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yut23
added
tests: running tests
yut23
force-pushed
the
build/more_wheel_testing
branch
2 times, most recently
from
c22f418
to
d78e3aa
Compare
yut23
force-pushed
the
build/more_wheel_testing
branch
from
d78e3aa
to
abcea5d
Compare
2 tasks
neutrinoceros
approved these changes
May 30, 2024
There was a problem hiding this comment.
Thank you for continuing this thread ! Obviously jobs are longer now: builds complete in about 45min (wall time) instead of 15, but that's a perfectly reasonable amount of time to wait for a release IMO. I'm approving now, but I'll give some time (say a week or two) for others to review.
chrishavlin
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The changes to pyproject.toml are needed to allow running the tests on the installed version of the code. The
--ignorepaths are resolved relative to the current directory before being compared to the test files if they're not already absolute. This works fine when running from the repository root, but pytest would have to be run fromsite-packages/to get the same relative file paths and it would try to run the tests of every installed package.--rootdir .makes pytest collect the tests from the installed package instead of the parent directory of the configuration file.PR Checklist