Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on GitHub #193

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Release on GitHub #193

merged 1 commit into from
Sep 15, 2020

Conversation

hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Sep 7, 2020

This will upload libaries artifacts to github release like
https://github.com/hannesa2/ioio/releases/tag/6.0.0-beta4.r20

@hannesa2 hannesa2 changed the title GitHub release Release on GitHub Sep 7, 2020
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Sep 7, 2020

Now I wait for secret GITHUBTOKEN like this

image

@topherbuckley
Copy link
Contributor

Is there a reason this is not handled by jitpack? Seems like duplicate generation of aar files no?

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Sep 9, 2020

Is there a reason this is not handled by jitpack? Seems like duplicate generation of aar files no?

Jitpack has currently only Android aar , for PC the *.jar files are now on github, it's a kind of replace of directory releases and move stuff to github https://github.com/ytai/ioio/releases with artifacts

@topherbuckley
Copy link
Contributor

Jitpack has currently only Android aar

Is that true? The doc link I sent seems to indicate you can also generate JAR files and points to this file as an example.

It'd be nice if they were all in the same place if possible, but I agree that github releases make more sense than a releases folder.

@hannesa2
Copy link
Collaborator Author

Jitpack has currently only Android aar

Is that true? The doc link I sent seems to indicate you can also generate JAR files and points to this file as an example.

It'd be nice if they were all in the same place if possible, but I agree that github releases make more sense than a releases folder.

Now https://jitpack.io/#ytai/ioio/6.0.0.beta6 has *.jar as well

image

@hannesa2 hannesa2 removed the blocked label Sep 15, 2020
@hannesa2 hannesa2 merged commit 3fab540 into master Sep 15, 2020
@hannesa2 hannesa2 deleted the GithubRelease branch September 15, 2020 04:47
@topherbuckley
Copy link
Contributor

Nice job!

One issue I see with these still though is there doesn't appear to be any release notes, or anything to differentiate between releases.

Is there a way to add release notes to these detailing what has been updated? It would likely take a bit more work to write these nicely for all beta releases, but at the very least, could we maybe just bundle all the master branch commit messages between the release and the previous release? For example I don't know if the newer releases are based on the AppCompat libraries or not without downloading the whole set and testing whether it breaks my project or not.

@topherbuckley topherbuckley mentioned this pull request Sep 16, 2020
@topherbuckley
Copy link
Contributor

Never mind. I had no idea github could do a diff on them directly. Not need for release notes if that is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants