Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore intercept if compiled class is equals abstract #41

Merged
merged 3 commits into from
Mar 13, 2017

Conversation

feralc
Copy link

@feralc feralc commented Mar 10, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.821% when pulling ec049bf on felipeweb11:master into 2628597 on ytake:master.

@@ -46,6 +46,10 @@ public function __construct(Container $container)
*/
public function intercept($abstract, Bind $bind, $className)
{
if ($abstract == $className) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use strict comparisons (===, !==)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.821% when pulling 37200d4 on felipeweb11:master into 2628597 on ytake:master.

@ytake ytake merged commit be33e55 into ytake:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants