Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Rotation issue #1

Closed
Vaberer opened this issue Jul 22, 2015 · 4 comments
Closed

On Rotation issue #1

Vaberer opened this issue Jul 22, 2015 · 4 comments

Comments

@Vaberer
Copy link

Vaberer commented Jul 22, 2015

Hello, I have just used your library. It looks very convenient and great. But I found out, there is an issue, if I rotate a phone, menu will not adjust properly.

@ytakzk ytakzk closed this as completed in 07e2fac Jul 22, 2015
@ytakzk
Copy link
Owner

ytakzk commented Jul 22, 2015

I already worked on this and pushed the revised version just now.
It still needs refactoring but it works correctly.
Thank you!

@Vaberer
Copy link
Author

Vaberer commented Jul 22, 2015

Good job! I was looking at your code and how it is written. I wanted to fix it by myself but I have more experience with creating UI with constraints instead of autoresizing masks and frames.

Did you try to create UI only with constraints programmatically?

@ytakzk
Copy link
Owner

ytakzk commented Jul 23, 2015

I wanted to use constraints but found that it takes more time for me to implement with constraint than with frames without a storyboard.
I will try to rewrite with constraints in the near feature but your pull request of the implementation is always welcome!

@Vaberer
Copy link
Author

Vaberer commented Jul 23, 2015

When I started using constraints, it was a little bit challenging, but now it is quite easy:)

Once again, good job:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants