Skip to content
This repository has been archived by the owner on Nov 5, 2020. It is now read-only.

feat: Inbuilt mp3 player #35

Merged
merged 36 commits into from
Apr 30, 2020
Merged

feat: Inbuilt mp3 player #35

merged 36 commits into from
Apr 30, 2020

Conversation

roerohan
Copy link
Collaborator

  • Uses ffmpeg and speaker to play mp3 from stream
  • Player is now abstract, AudioPlayer and VideoPlayer implement it.
  • play() function returns a Player object.

@roerohan
Copy link
Collaborator Author

roerohan commented Apr 29, 2020

Issues

  • sudo apt-get install libasound2-dev is needed on Ubuntu/Debian operating systems for npm install to succeed
  • Include ffmpeg binaries
  • Write a script to check if libasound2-dev is present, if not, prompt the user or install it.
  • Catch syntax error for invalid json.

@roerohan roerohan closed this Apr 29, 2020
@roerohan roerohan reopened this Apr 29, 2020
@roerohan roerohan requested a review from thebongy April 29, 2020 23:57
Copy link
Collaborator Author

@roerohan roerohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI/CD npm test fails due to some ALSA error.
@thebongy , how can we fix this?

TODO:

  • Include ffmpeg binaries.
  • Catch syntax error for invalid json.

@thebongy
Copy link
Collaborator

Need some updates in the README about node-gyp deps on windows

@roerohan
Copy link
Collaborator Author

TODO

  • README.md still has to be updated. @thebongy

Done

  • Added progress bar only for CLI.
  • ESLint accept extraneous dependency since node-speaker is in optionalDependencies.

@roerohan
Copy link
Collaborator Author

We'll update the README in the next version, I have added basic information.

@roerohan roerohan closed this Apr 30, 2020
@roerohan roerohan reopened this Apr 30, 2020
@roerohan roerohan merged commit 125cb11 into master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants