Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Interrupt an ongoing YouTube broadcast/live stream download on Windows will generate broken video file #21342
Labels
Comments
fireattack
changed the title
|
This is a Windows issue due to the way that Windows allows programs to communicate with signals. |
|
I cannot reproduce: I normally use linux. But I wanted to try and reproduce this on my windows 10 VM. I downloaded youtube-dl, ffmpeg, and the Msft Vis C++ 2010 pkg as required. Also, here is result of ffprobe on your test file:
Test 1 (https://www.youtube.com/watch?v=20NqRnLWLEo):Test 2 (https://www.youtube.com/watch?v=20NqRnLWLEo) with
|
|
I can still reproduce this bug, even with the one @namekal tried (https://www.youtube.com/watch?v=20NqRnLWLEo). Maybe it's something related to VM in his case? I tried it on different computers. Computer 1 with Win 7: Computer 2 (with Win 10): @dstftw: How should I prove it otherwise? From what @ealgase implies, I think this issue is not limited to myself. Thanks. |
|
Ah, I think I figured out why. I downloaded newest Nightly build of FFMPEG (as I observed from @namekal's test, and it indeed generates the expected result. I should note a major difference I found: With newest ffmpeg, if you press ctrl+C, it will NOT immediately stop the process, but wait a few seconds to end it properly. This is not the case when I was using stable release, which will immediately shut off the process. I believe this perhaps is the reason behind it. Again, thanks for everyone's time. |
|
This should be reopened as I can consistently reproduce the bug. I have a timing issue, e.g. the file is either completed succesfully or completely broken, depends on the moment you press ^C. To interrupt succesfully, I press ^C once when I see the frame=x, fps=y,.... ffmpeg status line. Pressing ^C more than once or in another moments breaks the file. |
|
Having this issue too when I attempt to download a VLive livestream (not vod) Command: I use --no-part because I have no idea how to work around ffprobe results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verbose log
Description
The file is broken and can't be played with any player. There is no error during the process.
Sample: file_sample.zip
I can reproduce this bug on multiple Win 7 and Win 10 computers.
I cannot reproduce this bug with Ubuntu as mentioned in #21255.