[OnePieceTube] Add new extractor #12305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Feb 28, 2017
| # coding: utf-8 | ||
| from __future__ import unicode_literals | ||
|
|
||
| import lxml.html |
|
|
||
| def _real_extract(self, url): | ||
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage(url, 'OnePiece-Tube') |
There was a problem hiding this comment.
Second parameter must be video id.
|
|
||
| # Try meta information title | ||
| if title is None: | ||
| for elem in root.xpath('//meta[@name="title"]/@content'): |
| url = self._search_regex(r'file: ["\'](?P<url>https?://[a-zA-Z0-9/\-\.]*?.mp4)["\']', webpage, 'url', group='url') | ||
|
|
||
| # Get Thumbnail | ||
| thumbnail = 'http:' + self._search_regex(r'image: ["\'](?P<thumb>//[a-zA-Z0-9/\-\.]*?.jpg)["\']', webpage, 'thumb', group='thumb', default=None) |
There was a problem hiding this comment.
'http:' + None = TypeError
| webpage = self._download_webpage(embed_url, 'anistream.com') | ||
|
|
||
| # Get real location of file | ||
| url = self._search_regex(r'file: ["\'](?P<url>https?://[a-zA-Z0-9/\-\.]*?.mp4)["\']', webpage, 'url', group='url') |
There was a problem hiding this comment.
No sense to use named group when it's the only one.
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage(url, 'OnePiece-Tube') | ||
|
|
||
| # Compose title information so far |
There was a problem hiding this comment.
Remove all pointless comments.
|
This website seems distributing copyrighted products: https://www.google.com/transparencyreport/removals/copyright/searchdata/domains/?id=onepiece-tube.com By the way, all pages on http://onepiece-tube.com/ are 404 from here Update: the site is back. http://onepiece-tube.com/folge/778 is a copyrighted product of Toei Animation. [1] Did they bought legal copyrights from copyright holders? |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
An extractor for the site onepiece-tube.com