Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gogoanime] Add new extractor #13076

Closed
wants to merge 1 commit into from

Conversation

michaelbukachi
Copy link

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description

added gogoanime extractor

@dstftw
Copy link
Collaborator

dstftw commented May 13, 2017

youtube-dl does not support sites dedicated to copyright infringement.

@CHJ85
Copy link

CHJ85 commented Mar 14, 2021

Do you think you could update this extractor, @michaelbukachi

@michaelbukachi
Copy link
Author

@CHJ85 I don't think I can. Because it violates copyright infringement

@CHJ85
Copy link

CHJ85 commented Mar 14, 2021

@michaelbukachi True. Using this code would violate copyright infringement because GoGoAnime is a pirate site. Hence why they haven't added the extractor to youtube-dl.
But you can still update the code.
If you don't wanna do that, can you at least tell me what changes I have to make in order to get the extractor working again?

@michaelbukachi
Copy link
Author

@michaelbukachi True. Using this code would violate copyright infringement because GoGoAnime is a pirate site. Hence why they haven't added the extractor to youtube-dl.
But you can still update the code.
If you don't wanna do that, can you at least tell me what changes I have to make in order to get the extractor working again?

When I worked on this PR initially, I wasn't aware of the copyright infringement policies. If I knew it beforehand, I wouldn't create the PR in the first place. Now that I'm aware, I'm not willing to do any updates to the code. You can use the code as a reference and make changes accordingly.

@CHJ85
Copy link

CHJ85 commented Mar 17, 2021

@michaelbukachi You didn't know that a website where people can watch anime illegally would be a violation? I sure buy that story (not).
What's the real reason? Why are you now (only a few years later) all of a sudden morally against updating the code?
Can you at the very least tell me in the comments here what changes I have to make in the code? Because I've been looking at this code and trying different things with no luck. Completely stuck.
For instance, I have no idea how/where to find the md5.

@michaelbukachi
Copy link
Author

@michaelbukachi You didn't know that a website where people can watch anime illegally would be a violation? I sure buy that story (not).
What's the real reason? Why are you now (only a few years later) all of a sudden morally against updating the code?
Can you at the very least tell me in the comments here what changes I have to make in the code? Because I've been looking at this code and trying different things with no luck. Completely stuck.
For instance, I have no idea how/where to find the md5.

Feel free to believe what you want. My decision is still the same. Have a good day.

@CHJ85
Copy link

CHJ85 commented Jul 5, 2023

Could you please update this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants