Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpac] Add new extractor #18265

Closed
wants to merge 2 commits into from
Closed

[cpac] Add new extractor #18265

wants to merge 2 commits into from

Conversation

ealgase
Copy link
Contributor

@ealgase ealgase commented Nov 21, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This adds an extractor for cpac.ca, closing #18148. Livestreams still need to be supported, as well as multiple languages for videos.

@ealgase ealgase changed the title Cpac [cpac] Add new extractor Nov 21, 2018
'formats': formats,
'title': title,
'description': description,
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This should use _search_json_ld.
  2. This should be done in generic extractor.
  3. _search_json_ld should be extended to be able to process all JSON-LD entries when expected_type is specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New site support: http://www.cpac.ca/
2 participants