[dnb] Add new extractor #18725
Closed
[dnb] Add new extractor #18725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
strange... Example: $ python3 -m youtube_dl https://portal.dnb.de/audioplayer/do/show/107679887X
[DNB] 107679887X: Downloading webpage
[download] Downloading playlist: None
[DNB] playlist None: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
ERROR: unable to download video data: HTTP Error 404: Not Found
$ python3 -m youtube_dl https://portal.dnb.de/audioplayer/do/show/107679887X
[DNB] 107679887X: Downloading webpage
[download] Downloading playlist: None
[DNB] playlist None: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[download] Destination: Gavotte und Bourée aus der 'Französischen Suite Nr. 5' [Elektronische Ressource] _ Johann Sebastian Bach-107679887X.mp3
[download] 100% of 4.48MiB in 00:01
[download] Finished downloading playlist: NoneHere are some urls to test with: |
dstftw
requested changes
Jan 3, 2019
|
|
||
|
|
||
| class DNBIE(InfoExtractor): | ||
| _VALID_URL = r'https?://(?:portal\.dnb\.de/audioplayer/do/show/|d-nb\.info/)(?P<id>\w+)[/&]?' |
There was a problem hiding this comment.
[/&]? does not make any sense at the end.
| }] | ||
|
|
||
| @staticmethod | ||
| def update_and_return_dic(info_dict, update_info): |
| 'id': obj.get('idn'), | ||
| 'title': obj.get('title'), | ||
| 'author': obj.get('author'), | ||
| 'url': 'https://portal.dnb.de/' + obj.get('media_url'), |
| for obj in objs: | ||
| thumbnail = obj.get('cover_url') | ||
| if thumbnail: | ||
| thumbnail = 'https://portal.dnb.de/' + thumbnail |
|
|
||
| info_dict = { | ||
| 'id': obj.get('idn'), | ||
| 'title': obj.get('title'), |
There was a problem hiding this comment.
Mandatory. Read coding conventions.
| webpage = self._download_webpage(url, video_id) | ||
|
|
||
| m = re.search(r'fdnbpl.media\s*=\s*(\[.*\]);', webpage) | ||
| objs = json.loads(m.group(1)) |
There was a problem hiding this comment.
_search_regex, _parse_json. Again: read coding conventions.
dstftw
force-pushed
the
master
branch
2 times, most recently
from
7b956a1
to
5e26784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
New extractor for e.g. https://portal.dnb.de/audioplayer/do/show/1077188552