-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SenateFloorGranicus] Add new extractor #22181
Conversation
|
That's the host documented in this stack overflow from a year ago... admittedly odd! http://archive-media.granicus.com/ works, too, now, in a browser window, but
I pushed up a small change to VALID_URL to make it just a little easier to remove :443 from the url later, if and when we need to. |
3186c4a
to
147ac88
Compare
147ac88
to
f47bb41
Compare
The latest update generalizes URL regexes more. This should make it easier to copy and paste to create extractors for other organizations using granicus.com. I wonder whether there's an even more general way to write this? I had no luck with a quick try at separate granicus and senate floor extractors. |
The current version of youtube-dl, 2019.10.22, remains unable to download the video at urls like https://floor.senate.gov/MediaPlayer.php?view_id=2&clip_id=3125 This PR, rebased on current master, continues to enable these downloads. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
A new extractor enabling download of US Senate videos linked from https://www.senate.gov/floor/ and hosted by granicus.com.
This PR addresses recent comments at issue #13399.