[sexdotcom] Add new extractor #22797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three different cases are handled: 1. Most video pages use the Video.js framework. I extract the arguments of the JavaScript `player.updateSrc()` call to get the video details (one or two different formats) 2. Some video pages include an iframe which embeds a video from another site, such as YouTube, XHamster, XVideos and possibly more. 3. Also supports `<img>` tag for gifs or plain simple pictures. This does not yet extract any metadata besides the essentials.
axelerometer
force-pushed
the
sexdotcom-ie
branch
from
b0eff9d
to
3a8aa2a
Compare
|
Covered by generic extractor. |
No it isn't. The generic extractor downloads some random wrong video or an advertisement. Please reopen. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR implements an extractor for Sex.com.
Three different cases are handled:
player.updateSrc()call to get the video details (one or two different formats)<img>tag for gifs or plain simple pictures.This does not yet extract any metadata besides the essentials. I'd prefer to get the basic functionality in first and follow up with that in a separate PR.