[hanime] Add new extractor #24328
Closed
[hanime] Add new extractor #24328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Read coding conventions. |
Calculate TBR from Filesize and Duration, if provided Use parsing and conversion functions
on int_or_none and float_or_none
|
Did that cover all convention recommendations or I still missed anything? |
dstftw
requested changes
Mar 12, 2020
youtube_dl/extractor/hanime.py
Outdated
| video_slug = self._match_id(url) | ||
|
|
||
| webpage = self._download_webpage(url, video_slug) | ||
| page_json = self._html_search_regex(r'window.__NUXT__=(.+?);<\/script>', webpage, 'Inline JSON') |
There was a problem hiding this comment.
- Extract dict if you expect dict.
- Relax regex.
- Escape dots.
youtube_dl/extractor/hanime.py
Outdated
|
|
||
| webpage = self._download_webpage(url, video_slug) | ||
| page_json = self._html_search_regex(r'window.__NUXT__=(.+?);<\/script>', webpage, 'Inline JSON') | ||
| page_json = self._parse_json(page_json, video_slug).get('state').get('data').get('video').get('hentai_video') |
There was a problem hiding this comment.
Read coding conventions on mandatory data.
youtube_dl/extractor/hanime.py
Outdated
| 'API Call', headers={'X-Directive': 'api'}).get('videos_manifest').get('servers')[0].get('streams') | ||
|
|
||
| title = page_json.get('name') or api_json.get[0].get('video_stream_group_id') | ||
| tags = [t.get('text') for t in page_json.get('hentai_tags')] |
youtube_dl/extractor/hanime.py
Outdated
|
|
||
| formats = [] | ||
| for f in api_json: | ||
| item_url = url_or_none(f.get('url')) or url_or_none('https://hanime.tv/api/v1/m3u8s/%s.m3u8' % f.get('id')) |
BrutuZ
commented
Mar 13, 2020
Iterate over server list instead of always using first index Add a couple fallbacks
dstftw
requested changes
Mar 14, 2020
youtube_dl/extractor/hanime.py
Outdated
| 'https://members.hanime.tv/api/v3/videos_manifests/%s' % video_slug, | ||
| video_slug, | ||
| 'API Call', headers={'X-Directive': 'api'}), lambda x: x['videos_manifest']['servers'], list) or [] | ||
| title = page_json.get('name') |
youtube_dl/extractor/hanime.py
Outdated
| video_slug, | ||
| 'API Call', headers={'X-Directive': 'api'}), lambda x: x['videos_manifest']['servers'], list) or [] | ||
| title = page_json.get('name') | ||
| duration = parse_duration('%sms' % page_json.get('duration_in_ms')) |
There was a problem hiding this comment.
Again: float_or_none, not parse_duration.
youtube_dl/extractor/hanime.py
Outdated
| title = page_json.get('name') | ||
| duration = parse_duration('%sms' % page_json.get('duration_in_ms')) | ||
| tags = [] | ||
| for tag in page_json.get('hentai_tags'): |
youtube_dl/extractor/hanime.py
Outdated
|
|
||
| def _real_extract(self, url): | ||
| video_slug = self._match_id(url) | ||
| page_json = self._html_search_regex(r'<script>.+__NUXT__=(.+?);<\/script>', self._download_webpage(url, video_slug), 'Inline JSON') |
youtube_dl/extractor/hanime.py
Outdated
| for stream in server['streams']: | ||
| if stream.get('compatibility') != 'all': | ||
| continue | ||
| item_url = sanitize_url(stream.get('url')) or sanitize_url('https://hanime.tv/api/v1/m3u8s/%s.m3u8' % stream.get('id')) |
| format = { | ||
| 'width': width, | ||
| 'height': height, | ||
| 'filesize_approx': float_or_none(parse_filesize('%sMb' % stream.get('filesize_mbs'))), |
youtube_dl/extractor/hanime.py
Outdated
Comment on lines
93
to
94
| {'preference': 0, 'id': 'Poster', 'url': page_json.get('poster_url')}, | ||
| {'preference': 1, 'id': 'Cover', 'url': page_json.get('cover_url')}, |
|
Since I'm not an actual programmer, could I kindly ask to get more than a couple words on the requested changes? Laconic answers can (and some have) become a time-consuming guessing game 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Extractor for hanime.tv (NSFW) using as many fields as they provide