-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Veeps] add extractor #25822
[Veeps] add extractor #25822
Conversation
|
5e26784
to
da2069f
Compare
@dunnousername THANK YOU for this. i was able to install by modifying an archlinux AUR packagebuild and pointing it to your repo/branch instead. worked great for the two shows on veeps i just tried! looking forward to seeing this in master. |
I can confirm this code works fine on release 2021.03.14 of youtube-dl. If I can assist in privately providing an account to test with, @dstftw, please let me know. Is the only thing stopping the merge that the tests do not pass, or is there anything else from the coding conventions that is missing? |
Confirmed this code works fine for me as well on OS X on 2021.03.14. The only possible issue is the default selection of a lower resolution than maximum, but that can be worked around with |
Hey @dunnousername, your repo disappeared with the DCMA takedowns. Would you care to put it back up? I'd give my own shot at implementing this, but since you already has successful pre-work, I'd rather use that. :) |
It's still sort of up. When the whole thing happened, I think my veeps repo also got taken down, but I forked a different version of My git diffs seem to still be in the "Files Changed" tab, though, as well as here, for some reason. |
Ah, I recall, the DMCA takedowns left the actual objects intact. That's why your commit can still be seen, and possibly, your pull request is still active, but the tree cannot be browsed. Anyway, I am testing your changes now - thanks for pointing out their location! I am tripping across an
backtrace. I'll look at whether I can get it to work in the first place (my Veeps link is only valid for a few more days). and then whether the code style remarks can be resolved. |
Patch revived and amended here: I understand the concerns about style (and other contribution rules). I may try to work on them, or just keep the patch around for myself, if I or your don't get around to polishing this. |
Unfortunately, Veeps have now changed their URL structure, and this extractor no longer works.. |
Here's another URL that also uses It is a freely available conference stream and does not require any authentication. ...and it looks like there is a demo site available from Mux: Here is an example stream: (source: |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
See issue #25728
This pull request adds an extractor for veeps.com. veeps.com hosts concert streams in which users can buy tickets and later replay the stream on the website. This extractor handles authentication (via the
--username
and--password
options) and downloading of streams when the user has purchased tickets. Because this extractor requires authentication and payment, there are currently no test cases written; however, I have tested it and the extractor correctly lists viewable formats and is able to download them and create a viewable stream. For details on how the testing was done, see the attached issue.URL format that this extractor accepts is
https://[channel].veeps.com/stream/[id]
.Here's a log from a test:
It will download the format specified and concatenate the stream's .ts files, saving a playable .mp4 file.