Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gab] Add new extractor #25886

Closed
wants to merge 2 commits into from
Closed

[Gab] Add new extractor #25886

wants to merge 2 commits into from

Conversation

runraid
Copy link

@runraid runraid commented Jul 4, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x ] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • [x ] New extractor
  • New feature

Description of your pull request and other information

This PR adds a new extractor to extract videos from https://gab.com/

#18226 requested it.

Copy link

@selfisekai selfisekai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • gab social is an open source, selfhostable and federated platform, the extractor should not be limited to just gab.com
  • gab social is a fork of mastodon, extractor should be renamed from gab to mastodon and be adjusted to work with tootsuite/mastodon
  • both mastodon and gab offer an open JSON REST API, maybe consider using it instead? https://docs.joinmastodon.org/methods/statuses/

@runraid
Copy link
Author

runraid commented Jul 11, 2020

No. You do it. I'll close this PR.

@runraid runraid closed this Jul 11, 2020
@selfisekai
Copy link

XDDDDDDDDDDDDDDDDDDDDDDDDDDDD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants