[Lumni] Add new extractor #26532
Closed
[Lumni] Add new extractor #26532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
|
Hi, Why has the "Lumni" commit not be applied? I'm eagerly waiting for it XD Thanks |
dirkf
requested changes
Jun 9, 2022
| @@ -580,6 +580,7 @@ | |||
| from .localnews8 import LocalNews8IE | |||
| from .lovehomeporn import LoveHomePornIE | |||
| from .lrt import LRTIE | |||
| from .lumni import LumniIE, LumniPlaylistIE | |||
There was a problem hiding this comment.
More maintainable:
Suggested change
| from .lumni import LumniIE, LumniPlaylistIE | |
| from .lumni import ( | |
| LumniIE, | |
| LumniPlaylistIE, | |
| ) |
Comment on lines
+67
to
+75
| entries = [self.url_result( | ||
| 'https://lumni.fr/video/%s' % video_id, | ||
| ie=LumniIE.ie_key(), video_id=video_id) | ||
| for video_id in orderedSet(re.findall( | ||
| r'<a[^>]+\bhref=["\']/video/([0-9a-z-]+)', webpage))] | ||
|
|
||
| playlist_title = self._og_search_title(webpage) | ||
|
|
||
| return self.playlist_result(entries, playlist_id, playlist_title) |
There was a problem hiding this comment.
There's a utility method for this; also the regex can be relaxed:
Suggested change
| entries = [self.url_result( | |
| 'https://lumni.fr/video/%s' % video_id, | |
| ie=LumniIE.ie_key(), video_id=video_id) | |
| for video_id in orderedSet(re.findall( | |
| r'<a[^>]+\bhref=["\']/video/([0-9a-z-]+)', webpage))] | |
| playlist_title = self._og_search_title(webpage) | |
| return self.playlist_result(entries, playlist_id, playlist_title) | |
| playlist_title = self._og_search_title(webpage) | |
| return self.playlist_from_matches( | |
| re.findall(r'''<a\b[^>]+\bhref\s*=\s*["']/video/([0-9a-z-]+)''', webpage), | |
| playlist_id, playlist_title, | |
| getter=lambda x: 'https://lumni.fr/video/' + x, | |
| ie=LumniIE.ie_key()) |
Comment on lines
+50
to
+52
| 'title': 'Les Fondamentaux : Vocabulaire', | ||
| }, | ||
| 'playlist_mincount': 39 |
There was a problem hiding this comment.
Currently these are right:
Suggested change
| 'title': 'Les Fondamentaux : Vocabulaire', | |
| }, | |
| 'playlist_mincount': 39 | |
| 'title': 're:(?i)^Les Fondamentaux : Vocabulaire$', | |
| }, | |
| 'playlist_mincount': 25 |
|
|
||
| from .common import InfoExtractor | ||
| from .francetv import FranceTVIE | ||
| from ..utils import orderedSet |
There was a problem hiding this comment.
Removed by final suggestion:
Suggested change
| from ..utils import orderedSet |
Comment on lines
+32
to
+34
| full_id = 'francetv:%s' % video_id | ||
|
|
||
| return self.url_result(full_id, |
There was a problem hiding this comment.
Roll this together:
Suggested change
| full_id = 'francetv:%s' % video_id | |
| return self.url_result(full_id, | |
| return self.url_result( 'francetv:' + video_id, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
French website for school children.
Requested in #24574 and #25772.