Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed VimeoIE so youtube-dl can download each video in a password pro… #27992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teesid
Copy link

@teesid teesid commented Jan 28, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fixed VimeoIE so youtube-dl can download each video in a password protected album (showcase).

Test url: https://vimeo.com/showcase/3253534/video/119195465
Password: youtube-dl

To test my case with my branch execute the following:
python test/test_download.py TestDownload.test_Vimeo_11

pukkandan pushed a commit to yt-dlp/yt-dlp that referenced this pull request Mar 7, 2021
nixxo pushed a commit to nixxo/yt-dlp that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants