Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/facebook] improve metadata extraction #29772

Closed
wants to merge 1 commit into from
Closed

[extractor/facebook] improve metadata extraction #29772

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Resolves # 29421, resolves # 23627, resolves # 23180

Improve title, add description. Prefer metadata in JSON-LD if present.

This PR doesn't touch playlists. Some tests (mostly of playlists) remain fail, and may need other PRs.
TestDownload.test_Facebook_7, 9, 10 (playlists)
TestDownload.test_Facebook_14 (get ERROR: Cannot parse data)

@ghost ghost closed this Aug 14, 2021
@ghost ghost deleted the improve-facebook-metadata branch August 15, 2021 04:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant