-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/facebook] Improve extraction #30700
base: master
Are you sure you want to change the base?
Conversation
* add another data structure for video extraction * modify metadata extraction due to site change
* avoid crashing in parse_attachment() on invalid attachment * ignore empty results in <meta> search
…ink, or not including the ID
The extractor does this thumbnail = html_search_meta_non_empty(
['og:image', 'twitter:image'], webpage, 'thumbnail', default=None) So it's looking for |
Facebook video downloading has issue now which was already filed before in several related/duplicated issues:
But it's working fine few days ago. Hopefully, this PR could be merged soon, since I badly needed the fix also. Thanks :) |
Are you saying that this happens with the PR code? Or (as I hope) that the PR code is still valid and fixes "Cannot parse data"? That message basically means that the extractor tried all the tactics it knows to extract from the page and none worked. |
Please follow the guide below
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR replaces #29796 which was orphaned when @kikuyan's account was deleted.
The PR makes the following fixes and improvements to the Facebook extractor:
attachment
s (from PR [extractor/facebook] fix extraction #30496, issue)ERROR: This video is only available for registered users.
) while it can be opened by a browser.The PR makes the following improvement to the
extractor/common.py
:InfoExtractor._json_ld()
(replaces PR [extractor/common] add SocialMediaPosting type to _json_ld() #30513).Resolves #29421, resolves #23627, resolves #23180, resolves #14156.
Resolves #30472, resolves #30474, resolves #30650, resolves #30681.
Closes #29796 (superseded)
Closes #30496 (superseded)
Closes #30513 (superseded).