Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for downloading multiple formats with --download-archive argument #7467

Closed
wants to merge 1 commit into from
Closed

Fix for downloading multiple formats with --download-archive argument #7467

wants to merge 1 commit into from

Conversation

dundua
Copy link
Contributor

@dundua dundua commented Nov 12, 2015

Fix for issue described in issue #7022

@dstftw
Copy link
Collaborator

dstftw commented Nov 12, 2015

record_download_archive must be called only after media was successfully downloaded and postprocessed. This change does not respect this at all. With this change video will be always written to archive even if it was skipped due to filters or one of simulate or --skip-download options, some error occured while downloading, some postprocessor failed, etc.

@dstftw dstftw closed this Nov 12, 2015
@dundua dundua mentioned this pull request Nov 12, 2015
Closed
@pukkandan pukkandan mentioned this pull request Oct 29, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dundua @dstftw