Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Migrate to youtube-dlc #123

Closed
FireMasterK opened this issue Oct 24, 2020 · 8 comments
Closed

Migrate to youtube-dlc #123

FireMasterK opened this issue Oct 24, 2020 · 8 comments
Labels
please test Issue is already solved, but still needs testing youtube Youtube-related issue

Comments

@FireMasterK
Copy link
Member

If you aren't aware, youtube-dl was hit with a DMCA takedown request at https://github.com/github/dmca/blob/master/2020/10/2020-10-23-RIAA.md

youtube-dlc is a fork of youtube-dl which is updated a lot more frequently and has a lot of features that youtube-dl doesn't have (for example, geo-blocking bypassing)

Repo Links:
https://pypi.org/project/youtube-dlc/
https://github.com/blackjack4494/yt-dlc

@pluja
Copy link
Member

pluja commented Oct 28, 2020

We are not using Youtube-dl anymore since 8efae82, we may be reimplementing it if I notice too much changes from Youtube interface so I don't need to maintain the 'data fetch API' which is a modified version of the one used by youtube-local.

@FireMasterK
Copy link
Member Author

Don't we use youtube-dl to fetch streams currently? It might be a wise idea to use youtube-dl to have lesser concerns with YouTube related changes such as #120.

(NewPipe has dealt with 3 changes Invidious has 2 dealt with in the past 2 weeks)

@pluja
Copy link
Member

pluja commented Oct 28, 2020

No, we currently don't depend on Youtube-dl in any way. But as I said, maybe it would be wise to use it in order to avoid future problems with Youtube changes.

@FireMasterK
Copy link
Member Author

That might be wise, I do see occasional errors(with no server-side logs) when Yotter tries to fetch the stream links.

@pluja
Copy link
Member

pluja commented Oct 30, 2020

Will be testing and fixing the following days. Will close this issue when we think that it works all ok and it is fine to use as definitive.

@pluja pluja added please test Issue is already solved, but still needs testing youtube Youtube-related issue labels Oct 30, 2020
@FireMasterK
Copy link
Member Author

From what I can see, it works fine 👍

@pluja
Copy link
Member

pluja commented Nov 6, 2020

Maybe we can close this issue? Do we agree that it is working fine?

@FireMasterK
Copy link
Member Author

Yep :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
please test Issue is already solved, but still needs testing youtube Youtube-related issue
Projects
None yet
Development

No branches or pull requests

2 participants