Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string preview in cell preview modal #765

Closed
Flunt1k opened this issue Sep 12, 2024 · 1 comment
Closed

Allow string preview in cell preview modal #765

Flunt1k opened this issue Sep 12, 2024 · 1 comment
Assignees
@Flunt1k

Comments

@Flunt1k
Copy link
Collaborator

Flunt1k commented Sep 12, 2024

Currently in modal user can view json/yson structures and also strings.
If only string in cell it needs to make 2 clicks:

  1. Click in cell on preview button
  2. Click in truncated string in modal

It seems that we can render string in <pre> directly in component without yson wrapper
@Flunt1k Flunt1k self-assigned this Sep 12, 2024
Flunt1k added a commit that referenced this issue Sep 12, 2024
@Flunt1k
fix(DataTableWrapper): fix check incomplete item in table [#765]
5122e88
Flunt1k added a commit that referenced this issue Sep 12, 2024
@Flunt1k
fix(StructuedYsonVirtualized): fix scroll for parsed string value [#765]
8bf76b6
Flunt1k added a commit that referenced this issue Sep 12, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
b92236d
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
fix(DataTableWrapper): fix check incomplete item in table [#765]
b6c8089
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
fix(StructuedYsonVirtualized): fix scroll for parsed string value [#765]
3cb05bf
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
test(Navigation/Table): add screenshot truncated struct data [#765]
24b1022
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
ebe6dd4
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
chore(Navigation/Table): add screenshot truncated struct data [#765]
d16bd48
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
e339686
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
fix(DataTableWrapper): fix check incomplete item in table [#765]
ea48f74
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
fix(StructuedYsonVirtualized): fix scroll for parsed string value [#765]
a033208
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
chore(Navigation/Table): add screenshot truncated struct data [#765]
14f5304
Flunt1k added a commit that referenced this issue Sep 16, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
f04235e
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
chore(Navigation/Table): add screenshot truncated struct data [#765]
064a413
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
3e3e5a8
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
fix(DataTableWrapper/YQLTable): fix check incomplete item in table [#765
ca22ea7 
]
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
fix(StructuedYsonVirtualized): fix scroll for parsed string value [#765]
b5f8405
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
chore(Navigation/Table): add screenshot truncated struct data [#765]
580f08a
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
49ba9ca
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
chore(Navigation/Table): add screenshot truncated struct data [#765]
dd46373
Flunt1k added a commit that referenced this issue Sep 17, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
cf70c8e
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
fix(StructuedYsonVirtualized): fix scroll for parsed string value [#765]
0960469
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
9dfa135
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
7987836 
…runcated table [#765]
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
c9a13f8
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
f316286 
…runcated table [#765]
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
b77dd2f
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
125aa53 
…runcated table [#765]
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
5041a9e 
…runcated table [#765]
Flunt1k added a commit that referenced this issue Sep 18, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
860f831 
…runcated table [#765]
Flunt1k added a commit that referenced this issue Sep 19, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
6834401 
…runcated table [#765]
Flunt1k added a commit that referenced this issue Sep 19, 2024
@Flunt1k
fix(StructuedYsonVirtualized): fix scroll for parsed string value [#765]
c696380
Flunt1k added a commit that referenced this issue Sep 19, 2024
@Flunt1k
feat(CellPreviewModal): add support string preview [#765]
e779d16
Flunt1k added a commit that referenced this issue Sep 19, 2024
@Flunt1k
chore(Navigation/DataTableWrapper): add e2e and screenshot test for t…
10763c8 
…runcated table [#765]
@github-actions github-actions bot mentioned this issue Sep 19, 2024
Merged
@Flunt1k
Copy link
Collaborator Author

Flunt1k commented Sep 19, 2024

Done

@Flunt1k Flunt1k closed this as completed Sep 19, 2024
This was referenced Sep 24, 2024
Merged
Merged
This was referenced Oct 2, 2024
Merged
Merged
This was referenced Oct 16, 2024
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 25, 2024
Merged
@github-actions github-actions bot mentioned this issue Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flunt1k Flunt1k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Flunt1k