Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better manage of the enable mode in edgeswitch.rb #2234

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

agabellini
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #2234 (0ef1263) into master (c0dae48) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   63.30%   63.19%   -0.11%     
==========================================
  Files          30       30              
  Lines        1496     1497       +1     
==========================================
- Hits          947      946       -1     
- Misses        549      551       +2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.35% <0.00%> (-1.66%) ⬇️
lib/oxidized/node.rb 70.83% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dae48...0ef1263. Read the comment docs.

@agabellini agabellini changed the title Update edgeswitch.rb Better manage of the enable mode in edgeswitch.rb Dec 17, 2020
Copy link

@MarcHagen MarcHagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! Thank you

@mortzu
Copy link
Collaborator

mortzu commented Nov 30, 2021

Can you add the change to the CHANGELOG, please?

@mortzu mortzu mentioned this pull request Dec 29, 2021
4 tasks
@mortzu
Copy link
Collaborator

mortzu commented Jan 26, 2022

Please process the checklist

@agabellini
Copy link
Contributor Author

Please process the checklist

I'm sorry, but I don't know how to do it :-(

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #2234 (0ef1263) into master (a36aece) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 0ef1263 differs from pull request most recent head aa5dece. Consider uploading reports for the commit aa5dece to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   63.28%   63.19%   -0.10%     
==========================================
  Files          30       30              
  Lines        1498     1497       -1     
==========================================
- Hits          948      946       -2     
- Misses        550      551       +1     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.35% <0.00%> (-1.66%) ⬇️
lib/oxidized/source/http.rb 40.81% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e423fff...aa5dece. Read the comment docs.

@mortzu mortzu merged commit 0eecddb into ytti:master Mar 24, 2022
@jplitza
Copy link
Contributor

jplitza commented Oct 10, 2023

Since this just bit me when updating (all backups of Edgeswitches suddenly just said "% Invalid input detected at '^' marker." since no enable command was sent anymore) I'll be so bold to simply ask: How do you configure an Edgeswitch to not require the "enable" command at all (not even a passwordless one)? o_O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants