Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure SSH session can end on Netgear correctly #2629

Merged
merged 3 commits into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- Cumulus: added option to use NCLU as ia collecting method
- Update net-ssh to 7.0.0.beta1 (using `append_all_supported_algorithms: true`)
- Allow (config) (vlan-####) confirmation (y/n) and sftp questions in procurve prompt (@sorano)
- fix: allow Netgear devices to finish SSH session correctly
- More pager handling for MIS5030Q (@glance-)
- Update logrotate example to allow logrotate service to start before any logs exist

Expand Down
4 changes: 3 additions & 1 deletion lib/oxidized/model/netgear.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ class Netgear < Oxidized::Model
# The system has unsaved changes.
# Would you like to save them now? (y/n)
#
# So it is safer simply to disconnect and not issue a pre_logout command
# As no changes will be made over this simple SSH session, we can safely choose "n" here.
pre_logout 'quit'
pre_logout 'n'
end

cmd :all do |cfg, cmdstring|
Expand Down