Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Some improvements #91

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Feature / Some improvements #91

merged 4 commits into from
Apr 1, 2020

Conversation

AurelienLoyer
Copy link
Collaborator

Description

✅Move firebase config in .env for soon staging part 🔪
✅Update all computed to mapState for prevent store trouble 😅
✅About page is back 🔫

Screenshot

About page:
image

GIF !

@github-actions github-actions bot added the Feature 🎉 New feature or request label Mar 31, 2020
@AurelienLoyer AurelienLoyer changed the title Feature/some improvement Feature / Some improvements Mar 31, 2020
ytvnr
ytvnr approved these changes Apr 1, 2020
View reviewed changes
Copy link
Owner

@ytvnr ytvnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very good work !

@ytvnr ytvnr merged commit c794664 into master Apr 1, 2020
@AurelienLoyer AurelienLoyer mentioned this pull request Apr 1, 2020
Closed
@AurelienLoyer AurelienLoyer deleted the feature/some-improvement branch April 2, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytvnr ytvnr ytvnr approved these changes

Assignees
No one assigned
Labels
Bug 🐜 Something isn't working Feature 🎉 New feature or request Technical task 👨🏻‍🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienLoyer @ytvnr