test duplicate username (fixed)

[saadben]

In the login response, we should have used "pack.userId = self.currentId" instead of pack.userId=0

[yuancheng-p]

I think if the user fail to login, he won't be allocated a userId, so we should keep it 0.

[saadben]

Yes, the way we implemented it is corret too. But if we want the test to pass, we'll need to allocate a new user Id (setting userId to -1 or -2 according to the error was too clever for their tests :D )

----- Mail original -----
De: "Yuancheng Peng" notifications@github.com
À: "yuancheng2013/c2w" c2w@noreply.github.com
Cc: "saadben" saad.bennanizoubir@telecom-bretagne.eu
Envoyé: Mercredi 16 Avril 2014 11:52:35
Objet: Re: [c2w] test duplicate username (fixed) (#3)

I think if the user fail to login, he won't be allocated a userId, so we should keep it 0.

—
Reply to this email directly or view it on GitHub .

[yuancheng-p]

I think you are talking about the test "trial_retransmit_one_user_login_udp_server_test.py".
I tried to fix this bug and I belive it's an error made by the professor. When a user want to login with a user name exist in the system, the server should send an error packet with error code!

[saadben]

For the "trial_retransmit_one_user_login_udp_server_test.py", I don't think it's an error in their test. Actually, a client sends a login request but the ack is lost, so he resends a request. The problem in the code is that we don't resend the same ACK again (as we're supposed to do) but we consider the second request as a duplicate login request...

[yuancheng-p]

fix with commit 2d85ccc