Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding layoutIterations() support #29

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

qknight
Copy link
Contributor

@qknight qknight commented Nov 20, 2023

I'm using the change in this PR already - so it probably can be merged I guess.

If you want to play with it:

https://echarts.apache.org/examples/en/editor.html?c=sankey-simple&lang=ts&version=5.4.4-dev.20231111&decal=1

option = {
  series: {
    type: 'sankey',
    layout: 'none',
    layoutIterations: 0,
    emphasis: {
        focus: 'adjacency'
    },
    data: [
{ name: 'b1' },
{ name: 'b' },
{ name: 'a' },
{ name: 'c' },
{ name: 'a1' },
{ name: 'a3' },
{ name: 'aa' },


    ],
    links: [
      {source: 'b',target: 'b1',value: 1},
      {source: 'a',target: 'a1',value: 5},
      {source: 'a',target: 'b1',value: 2},

      {source: 'b1',target: 'c',value: 2},
      {source: 'b1',target: 'a1',value: 1},
      {source: 'a',target: 'aa',value: 3},
      {source: 'aa',target: 'a3',value: 3},
    ]
  }
};

Copy link
Owner

@yuankunzhang yuankunzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks @flosse for reviewing it.

@yuankunzhang yuankunzhang merged commit 14c4cc9 into yuankunzhang:main Nov 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants