[yugabyte/yugabyte-db#20636] Fetch for tablets from service in snapshot phase as well #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The connector flow today is such that:
HashPartitions
are created and the partition keys are passed down to the tasksSolution
This diff implements a solution to the problem by making a call to
GetTabletListToPollForCDC
in the snapshot phase as well which then ensures that we are only receiving a valid set of tablets to poll.Testing
Tested manually using the following steps:
i. Without fix: The task will fail while trying to get the checkpoint of deleted parent tablet
ii. With fix: Connector proceeds to the streaming phase without any error
This fixes yugabyte/yugabyte-db#20636