Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single connection option #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yifanguan
Copy link
Contributor

Add a new command-line option: --single-transaction to examine RPC requests of a single random transaction.

Usage:
./tpccbenchmark --execute=true --single-transaction

@robertsami
Copy link
Contributor

@yifanguan this looks useful, but can you separate it from the RETURNING... clause changes and keep this PR scoped?

also, can we add an option to specify the the transaction you run? if not specified, maybe we run a random one, but otherwise we run the one specified?

@yifanguan
Copy link
Contributor Author

Rebase the PR to make it scoped.

I can definitely add an option to specify which transaction to examine (which HikariDataSource to get a connection) using nodes numbers (1, 2, 3, etc).
e.g. ./tpccbenchmark --execute=true --single-transaction 1
However, I'm not sure whether this can help us understand RPC requests better. Each time transactions are dynamically scheduled, I feel like this is random scheduling. Specifying a specific node number may not be helpful. Please correct me if I misunderstand anything.

@yifanguan yifanguan changed the title Single transaction option Single connection option Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants