Added enhancement for Gin Index not supported queries in analyze-sche… #499
Conversation
| @@ -197,6 +198,30 @@ func reportSummary() { | |||
| reportStruct.Summary.DBObjects = append(reportStruct.Summary.DBObjects, dbObject) | |||
| } | |||
| } | |||
| // Checks Whether there is a GIN index | |||
There was a problem hiding this comment.
In the comment, can you show examples (with full SQL DDL stmt) of all the scenarios reported by this function?
yb-voyager/cmd/analyzeSchema.go
Outdated
| // Checks Whether there is a GIN index | ||
| func checkGin(sqlInfoArr []sqlInfo, fpath string) { | ||
| for _, sqlInfo := range sqlInfoArr { | ||
| idx := ginRegex.FindStringSubmatch(sqlInfo.stmt) |
There was a problem hiding this comment.
It is a general practice to name the output of regex methods as match.
There was a problem hiding this comment.
I maintained the consistency as every where in the file, the output of regex methods is idx, I can change that for now only here and will take care of other places in the refactoring.
yb-voyager/cmd/analyzeSchema.go
Outdated
| columnsFromGin := strings.Trim(idx[4], `()`) | ||
| columnList := strings.Split(columnsFromGin, ",") | ||
| if len(columnList) > 1 { |
There was a problem hiding this comment.
Isn't it enough to check for the presence of a comma to conclude that it is an index on multiple columns?
| } | ||
| } | ||
| if strings.Contains(strings.ToLower(sqlInfo.stmt), "extension btree_gin") { | ||
| reportCase(fpath, "Schema contains btree_gin extension which is not supported for YB", |
There was a problem hiding this comment.
Can you define a local anonymous function to factor out common values:
reportFn := function(msg string, ghIssueID int, name string) {
reportCase(fpath, msg, fmt.Sprintf(""https://github.com/yugabyte/yugabyte-db/issues/%d", ghIssueID), "INDEX", name, sqlInfo.formattedStmtStr)
}
There was a problem hiding this comment.
@amit-yb now this should be considered in the refactoring of analyzeSchema later?
…ma (#428)
Added conditions for Unsupported Gin index queries (Support ticket on DB side : yugabyte/yugabyte-db#7850) -
Added check for btree_gin extension which can be created which means it exists in the Database but is not supported with YB gin indexes (Support ticket on DB side: yugabyte/yugabyte-db#9958).