[YSQL] Enable DDL atomicity feature by default #22097
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/new-feature
This is a request for a completely new feature
priority/medium
Medium priority issue
Comments
myang2021
added
area/ysql
yugabyte-ci
added
kind/new-feature
myang2021
removed
kind/new-feature
yugabyte-ci
added
kind/new-feature
myang2021
added a commit
that referenced
this issue
Apr 30, 2024
Summary: This diff enables DDL atomicity feature by default. (1) changing the default value of several gflags from false to true. --ysql_yb_ddl_rollback_enabled --report_ysql_ddl_txn_status_to_master --ysql_ddl_transaction_wait_for_ddl_verification (2) code cleanup related to (1), for example, some unit tests needed to explicitly enable one or more of these 3 gflags. Now that they are turned on by default, those code are removed. (3) other unit tests update related to (1). For example, in pg_packed_row-test.cc, the test output has changed from `PACKED_ROW[2]` to `PACKED_ROW[3]`. The number in the bracket represents the table schema version. With DDL atomicity, a DDL such as `ALTER TABLE test DROP COLUMN v2` causes the schema version of table test to bump by 2 after the DDL commits. Without DDL atomicity, the schema version of table test used to only bump up by 1 after the DDL commits. Jira: DB-11028 Test Plan: Jenkins run Reviewers: hsunder Reviewed By: hsunder Subscribers: ycdcxcluster, hsunder Differential Revision: https://phorge.dev.yugabyte.com/D30471
myang2021
added a commit
that referenced
this issue
Apr 30, 2024
Summary: This diff enables DDL atomicity feature by default. (1) changing the default value of several gflags from false to true. --ysql_yb_ddl_rollback_enabled --report_ysql_ddl_txn_status_to_master --ysql_ddl_transaction_wait_for_ddl_verification (2) code cleanup related to (1), for example, some unit tests needed to explicitly enable one or more of these 3 gflags. Now that they are turned on by default, those code are removed. (3) other unit tests update related to (1). For example, in pg_packed_row-test.cc, the test output has changed from `PACKED_ROW[2]` to `PACKED_ROW[3]`. The number in the bracket represents the table schema version. With DDL atomicity, a DDL such as `ALTER TABLE test DROP COLUMN v2` causes the schema version of table test to bump by 2 after the DDL commits. Without DDL atomicity, the schema version of table test used to only bump up by 1 after the DDL commits. Jira: DB-11028 Original commit: 1bbe619 / D30471 Test Plan: Jenkins run Reviewers: hsunder Reviewed By: hsunder Subscribers: hsunder, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34636
svarnau
pushed a commit
that referenced
this issue
May 25, 2024
Summary: This diff enables DDL atomicity feature by default. (1) changing the default value of several gflags from false to true. --ysql_yb_ddl_rollback_enabled --report_ysql_ddl_txn_status_to_master --ysql_ddl_transaction_wait_for_ddl_verification (2) code cleanup related to (1), for example, some unit tests needed to explicitly enable one or more of these 3 gflags. Now that they are turned on by default, those code are removed. (3) other unit tests update related to (1). For example, in pg_packed_row-test.cc, the test output has changed from `PACKED_ROW[2]` to `PACKED_ROW[3]`. The number in the bracket represents the table schema version. With DDL atomicity, a DDL such as `ALTER TABLE test DROP COLUMN v2` causes the schema version of table test to bump by 2 after the DDL commits. Without DDL atomicity, the schema version of table test used to only bump up by 1 after the DDL commits. Jira: DB-11028 Test Plan: Jenkins run Reviewers: hsunder Reviewed By: hsunder Subscribers: ycdcxcluster, hsunder Differential Revision: https://phorge.dev.yugabyte.com/D30471
ZhenYongFan
pushed a commit
to ZhenYongFan/yugabyte-db
that referenced
this issue
Jun 15, 2024
Summary: This diff enables DDL atomicity feature by default. (1) changing the default value of several gflags from false to true. --ysql_yb_ddl_rollback_enabled --report_ysql_ddl_txn_status_to_master --ysql_ddl_transaction_wait_for_ddl_verification (2) code cleanup related to (1), for example, some unit tests needed to explicitly enable one or more of these 3 gflags. Now that they are turned on by default, those code are removed. (3) other unit tests update related to (1). For example, in pg_packed_row-test.cc, the test output has changed from `PACKED_ROW[2]` to `PACKED_ROW[3]`. The number in the bracket represents the table schema version. With DDL atomicity, a DDL such as `ALTER TABLE test DROP COLUMN v2` causes the schema version of table test to bump by 2 after the DDL commits. Without DDL atomicity, the schema version of table test used to only bump up by 1 after the DDL commits. Jira: DB-11028 Original commit: 1bbe619 / D30471 Test Plan: Jenkins run Reviewers: hsunder Reviewed By: hsunder Subscribers: hsunder, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-11028
Description
Currently the DDL atomicity feature is turned off by default. All the jenkins tests are passing with the feature turned on so it is ready for turning on by default.
This involves changing the default value of several gflags from false to true.
Issue Type
kind/new-feature
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: