Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector test method pollutes DOM nodes with ID. #1925

Open
ipeychev opened this issue Aug 3, 2014 · 0 comments
Open

Selector test method pollutes DOM nodes with ID. #1925

ipeychev opened this issue Aug 3, 2014 · 0 comments
Labels
bug

Comments

@ipeychev
Copy link
Contributor

ipeychev commented Aug 3, 2014

If there is no ID, Selector adds an auto generated one. However, its been never removed and this breaks inline editing if an third party editor is used, like CKEditor for example.

Here is the code:

yui3/src/dom/js/selector-native.js

Line 334 in 10d1cd5

Y.DOM.setId(node, id);

@ipeychev ipeychev added the bug label Aug 3, 2014
ipeychev added a commit to ipeychev/yui3 that referenced this issue Aug 3, 2014
@ipeychev
[selector] Remove auto added ID on testing for selector
05e03c5 
Fixes yui#1925
This was referenced Aug 3, 2014
Closed
Open
jonmak08 pushed a commit to jonmak08/yui3 that referenced this issue Oct 11, 2014
@ipeychev
Remove auto added ID on testing for selector
a42d780 
Fixes yui#1925
ipeychev added a commit to liferay/yui3 that referenced this issue Oct 16, 2014
@ipeychev @mairatma
Remove auto added ID on testing for selector
da090ac 
Fixes yui#1925
@sei-dmorda sei-dmorda mentioned this issue Dec 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[selector] Remove auto added ID on testing for selector ipeychev/yui3
1 participant
@ipeychev