New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left/right margin issues with dual-panel calendars #1749

Merged
merged 1 commit into from May 8, 2014

Conversation

Projects
None yet
6 participants
@andrewnicols
Contributor

andrewnicols commented Apr 3, 2014

No description provided.

@yahoocla

This comment has been minimized.

yahoocla commented Apr 3, 2014

CLA is valid!

@andrewnicols

This comment has been minimized.

Contributor

andrewnicols commented Apr 3, 2014

LTR:
dualview-ltr

RTL at present state of dev-3.x:
dualview-rtl

RTL with the applied change:
dualview-rtl-after

@andrewnicols

This comment has been minimized.

Contributor

andrewnicols commented Apr 3, 2014

Build failing due to travis-ci/travis-ci#2076

@tilomitra

This comment has been minimized.

Contributor

tilomitra commented Apr 7, 2014

We should pull this in before 3.16.0 GA IMO. Reviewers, could you take a look at this?

@tilomitra

This comment has been minimized.

Contributor

tilomitra commented Apr 7, 2014

@andrewnicols What's the test page that you're using to test this? Can you put the HTML up somewhere?

@triptych

This comment has been minimized.

Contributor

triptych commented Apr 7, 2014

I don't think this is a release blocker, however it should definitely go into dev-3.x for next release.

@andrewnicols

This comment has been minimized.

Contributor

andrewnicols commented Apr 7, 2014

@tilomitra I'm testing with the two-pane calendar example in the build docs. E.g. the local equivalent of http://yuilibrary.com/yui/docs/calendar/calendar-multipane.html

Note: the one on yuilibrary.com isn't the best example for all of these issues (though it does exhibit this bug) because of the inclusion of CSS Grids from 3.9.0 instead of the relevant release (raised in #1712).

@okuryu

This comment has been minimized.

Member

okuryu commented Apr 8, 2014

I think that it is ok to merge, but this is just an enhancement not release blocker.

@ezequiel ezequiel merged commit dfe7efd into yui:dev-3.x May 8, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@ezequiel

This comment has been minimized.

Contributor

ezequiel commented May 8, 2014

Thanks.

@triptych

This comment has been minimized.

Contributor

triptych commented May 19, 2014

In the future, please include HISTORY.md updates in your PR @andrewnicols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment