Fix left/right margin issues with dual-panel calendars #1749

Merged
merged 1 commit into from May 8, 2014

Projects

None yet

6 participants

@andrewnicols
Contributor

No description provided.

@yahoocla
yahoocla commented Apr 3, 2014

CLA is valid!

@andrewnicols
Contributor

LTR:
dualview-ltr

RTL at present state of dev-3.x:
dualview-rtl

RTL with the applied change:
dualview-rtl-after

@andrewnicols
Contributor

Build failing due to travis-ci/travis-ci#2076

@tilomitra
Contributor

We should pull this in before 3.16.0 GA IMO. Reviewers, could you take a look at this?

@tilomitra
Contributor

@andrewnicols What's the test page that you're using to test this? Can you put the HTML up somewhere?

@triptych
Contributor
triptych commented Apr 7, 2014

I don't think this is a release blocker, however it should definitely go into dev-3.x for next release.

@andrewnicols
Contributor

@tilomitra I'm testing with the two-pane calendar example in the build docs. E.g. the local equivalent of http://yuilibrary.com/yui/docs/calendar/calendar-multipane.html

Note: the one on yuilibrary.com isn't the best example for all of these issues (though it does exhibit this bug) because of the inclusion of CSS Grids from 3.9.0 instead of the relevant release (raised in #1712).

@okuryu
Member
okuryu commented Apr 8, 2014

I think that it is ok to merge, but this is just an enhancement not release blocker.

@ezequiel ezequiel merged commit dfe7efd into yui:dev-3.x May 8, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@ezequiel
Member
ezequiel commented May 8, 2014

Thanks.

@triptych
Contributor

In the future, please include HISTORY.md updates in your PR @andrewnicols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment