Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute with a default String value that contains a space is parsed wrongfully #268

Closed
StephanBijzitter opened this issue Oct 27, 2014 · 3 comments · Fixed by #278
Closed

Attribute with a default String value that contains a space is parsed wrongfully #268

StephanBijzitter opened this issue Oct 27, 2014 · 3 comments · Fixed by #278
Assignees
@okuryu
Labels
bug
Milestone
v0.4.0

Comments

@StephanBijzitter
Copy link 

     * @param [options.position="50% 50%"] {String} The CSS `background-position` value
     *            for this instance.

Output:

[options.position="50% String
50%"] The CSS background-position value for this instance.

<li class="param" id="yui_3_9_1_2_1414406969858_446">
    <code class="param-name" id="yui_3_9_1_2_1414406969858_445">[options.position="50%</code>
    <span class="type"><a href="https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/String" class="crosslink external" target="_blank">String</a></span>                
    <div class="param-description">
        <p>50%"]  The CSS <code>background-position</code> value for this instance.</p>
    </div>
</li>

Screenshot of output: http://puu.sh/csyjj.png
Screenshot of inspector: http://puu.sh/csyiB.png
@StephanBijzitter StephanBijzitter changed the title Attribute with a default String value that contains a space terminates code Attribute with a default String value that contains a space is parsed wrongfully Oct 27, 2014
@okuryu
Copy link
Member

okuryu commented Oct 28, 2014

Thanks! It seems to be a bug. I'll take a look.

@okuryu okuryu added the bug label Oct 28, 2014
okuryu added a commit to okuryu/yuidoc that referenced this issue Nov 8, 2014
@okuryu
Fix fails to parse a default param value that contains a space
cc99c1e 
It changes to accept a spaces in optional params. This fixes yui#268.
@okuryu okuryu mentioned this issue Nov 8, 2014
Merged
@okuryu
Copy link
Member

okuryu commented Nov 8, 2014

Patch #278 is ready for reviews.

@okuryu okuryu mentioned this issue Nov 11, 2014
Closed
17 tasks
@okuryu okuryu self-assigned this Nov 11, 2014
@okuryu
Copy link
Member

okuryu commented Nov 14, 2014

#278 has been merged.

@okuryu okuryu added this to the v0.4.0 milestone Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okuryu okuryu

Labels
bug
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Fix fails to parse a default param value that contains a space okuryu/yuidoc
2 participants
@okuryu @StephanBijzitter