Fixes indents of templates and bumps YUI dependencies #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes yui#288. This problem is due to `Y.Handlebars` have been upgraded from v1.x to v2.0.0 since YUI 3.18.0. Handlebars v2.0.0 have been changed the handling of indents to matches to the Mustache specs. https://github.com/wycats/handlebars.js/blob/master/release-notes.md Therefore, it fixes indents of templates and I'd like to make clear YUIDoc uses Handlebars v2.0.0 by depending on YUI 3.18.1 or later.
|
CLA is valid! |
This was referenced Dec 2, 2014
|
Looks good.. thanks @okuryu, this is a better fix than mine where I just downgraded YUI. |
|
LGTM! |
|
Just spent a few hours debugging this issue in a custom theme, and thought I should mention that whitespace control is a slightly cleaner way to work around this issue: avoids the unwanted indentation. |
|
@NateEag Thanks for your information, I didn't know the workaround! I just updated YUIDoc v0.5.0 release note to add the mention of this problem. Please let me know if I'm wrong. |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #288. This problem is due to
Y.Handlebarshave been upgraded from v1.x to v2.0.0 since YUI 3.18.0.Handlebars v2.0.0 have been changed the handling of indents to matches to the Mustache specs.
https://github.com/wycats/handlebars.js/blob/master/release-notes.md
Therefore, it fixes indents of templates and I'd like to make clear YUIDoc uses Handlebars v2.0.0 by depending on YUI 3.18.1 or later.