Change the Markdown parser #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential security issues have been reported to the marked, but there is no plan to still be fixed. Because YUIDoc is a one of the development tool, I have thought unlikely to be affected by the problem. However, marked is no longer actively maintained, and I'd like to choice a parser that are more maintenance. Since YUIDoc only have utilized simply marked as a simple Markdown parser, change can often be reduced.
|
CLA is valid! |
| markdown: function (md) { | ||
| var html = marked(md, this.options.markdown); | ||
| markdown: function (data) { | ||
| var md = new MarkdownIt(this.options.markdown); |
There was a problem hiding this comment.
Can we create the instance only once? Also, what are the defaults for this.options.markdown?
|
Okay, changed to reuse an instance of MarkdownIt in an instance of DocBuilder. |
|
Looks good! |
|
Thanks a lot! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the Markdown parser from marked to markdown-it.
Potential security issues have been reported to the marked, but there is no plan to still be fixed. Because YUIDoc is an one of the development tool, I have thought unlikely to be affected by the problem. However, marked is no longer actively maintained, and I'd like to choice a parser that are more maintenance.
Since YUIDoc only have utilized simply marked as a simple Markdown parser, change can often be reduced.
/cc @juandopazo @caridy