Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug that inherited class was parsed twice (fixes #324) #341

Merged
merged 1 commit into from
Apr 12, 2015
Merged

Fix a bug that inherited class was parsed twice (fixes #324) #341

merged 1 commit into from
Apr 12, 2015

Conversation

okuryu
Copy link
Member

@okuryu okuryu commented Apr 9, 2015

All descriptions and examples of inherited classes was parsed markdown by markdown-it twice. This fixes #324.

@okuryu
Fix a bug that inherited class was parsed twice (fixes yui#324)
ca544f6 
All descriptions and examples of inherited classes was parsed markdown
by markdown-it twice. This fixes yui#324.
@yahoocla
Copy link

yahoocla commented Apr 9, 2015

CLA is valid!

@okuryu okuryu merged commit ca544f6 into yui:master Apr 12, 2015
@okuryu okuryu deleted the fix324 branch April 12, 2015 09:03
@okuryu okuryu added this to the v0.7.0 milestone Apr 12, 2015
@okuryu okuryu self-assigned this Apr 12, 2015
@dcleao
Copy link

dcleao commented Apr 14, 2015

I tried this fix and, apparently, it fixed everything except the "return description":

Returns:
Null | Object:
<p>A copy of the cell or <code>null</code>.</p>

@okuryu
Copy link
Member Author

okuryu commented Apr 15, 2015

@dcleao Good catch, I'll take a look ASAP. Thanks!

okuryu added a commit to okuryu/yuidoc that referenced this pull request Apr 15, 2015
@okuryu
Fix @returns tag of extended classes doesn't escape HTML (fixes yui#324)
17b11e2 
This is an additional fixes yui#324. See also yui#341.
@okuryu okuryu mentioned this pull request Apr 15, 2015
Merged
@hhff
Copy link

hhff commented Apr 15, 2015

thanks @okuryu ! when do you think you'll cut a new release?

@okuryu
Copy link
Member Author

okuryu commented Apr 15, 2015

@hhff I'm planning to release the next version within a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okuryu okuryu

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Inherited method description does not escape HTML
4 participants
@okuryu @yahoocla @dcleao @hhff