Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regex package bugs Fixes #1 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Kellel
Copy link

@Kellel Kellel commented May 19, 2017

Fix find by fixing the incorrect value in nil case
Re-write match to skip messy index logic
Also added two lines of tests that now work

Kellen Fox added 2 commits May 19, 2017 13:07
Fix find by fixing the incorrect value in nil case
Re-write match to skip messy index logic
@Kellel
Copy link
Author

Kellel commented May 19, 2017

So the thing that you probably are going to complain about is that I had to change one of your tests to get this to work.

So here is the decision you have to make:
a. Put even more work into this package to only return subs in complex captures.
b. Accept the way golang returns regex matches and go ahead and merge is as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant