Add support for Rails Cop

[richrace]

rubocop needs to be ran from the project directory where the Rails app lives to work. Therefore, if rubocop is used then change the CWD to the project path if the Rails flag has been set.

To enable this add rails: true to your config.cson e.g.

'atom-lint':
  'ignoredNames': [
    'tmp/**'
  ]
  'rubocop':
    'rails': true
    'ignoredNames': [
      'db/**'
      'spec/**'
    ]

All specs pass in Atom (0.118.0 using React Editor). Using the rake command one fails, but it also fails in master, hopefully a separate issue.

CommandRunner
  run
    when environment variables of the login shell cannot be fetched
      it runs the command with the current env

[yujinakayama]

Thanks for the pull request.

I agree that rubocop should be run in the project root directory. I also think all linter commands should alway be run there since it would make the logic simpler and there's no disadvantage.

[yujinakayama]

As I said, we can always set the cwd regardless whether the command is rubocop.

[richrace]

Ok sounds good.

Do you want me to close this PR and come back with a new one for just setting the cwd?

[yujinakayama]

Do you want me to close this PR and come back with a new one for just setting the cwd?

No you need not. You can add further changes in the current branch, squash the commits, and git push -f, then this pull request will be updated.

• https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#squash-your-changes-optional

[richrace]

Here we go. Will set the CWD for any linter.

[yujinakayama]

As noted above, could you remove the rails configuration option handling? I'm planning to add more generic option to specify CLI arguments.

[richrace]

This is ready to be merged now.

[yujinakayama]

Thanks!