Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/port for #54

Merged
merged 12 commits into from
Dec 23, 2023
Merged

Fix/port for #54

merged 12 commits into from
Dec 23, 2023

Conversation

yukihirop
Copy link
Owner

@yukihirop yukihirop commented Dec 23, 2023

Summary

Resolve ##53

Other Information

  • [Breaking] fix port_for logic.
    • Ports may be specified explicitly, so I stopped adjusting them automatically with app_index.
// before
pub fn port_for(env_path: &PathBuf, port: Option<u32>, app_index: usize, concurrency_index: usize) -> u32 { 
  base_port(env_path, port) + (app_index * 100 + concurrency_index) as u32 
} 

// after
pub fn port_for(env_path: &PathBuf, port: Option<u32>, concurrency_index: usize) -> u32 { 
  base_port(env_path, port) + concurrency_index
} 

Work

cd example/start
cargo run start -m web=3

Test

  • ci

@yukihirop yukihirop self-assigned this Dec 23, 2023
@yukihirop yukihirop added this to the v0.3.1 milestone Dec 23, 2023
@yukihirop yukihirop merged commit e5c478f into main Dec 23, 2023
4 checks passed
@yukihirop yukihirop deleted the fix/port_for branch December 23, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant