Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel mail produces ugly error on failure to send to an active domain #99

Closed
yungifez opened this issue Jul 15, 2022 · 2 comments · Fixed by #114
Closed

Laravel mail produces ugly error on failure to send to an active domain #99

yungifez opened this issue Jul 15, 2022 · 2 comments · Fixed by #114

Comments

@yungifez
Copy link
Owner

laravel/framework#33018

This can be useful on registration to prevent issues like

IMG-20220715-WA0056.jpg

This might however make testing a little bit more difficult but ensures non existent emails cannot sign up

@yungifez
Copy link
Owner Author

This also affects student creation as it involves db transactions which is not committed if the message isn't sent successfully

yungifez added a commit that referenced this issue Jul 21, 2022
yungifez added a commit that referenced this issue Jul 21, 2022
yungifez added a commit that referenced this issue Aug 16, 2022
yungifez added a commit that referenced this issue Aug 16, 2022
@yungifez
Copy link
Owner Author

Caught all exceptions but continued execution silently, this would still haunt me one day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant