[tool-maven] Add blog release generator maven cmd #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
approved these changes
Dec 15, 2022
| .build(); | ||
| try (final Jsonb jsonb = JsonbBuilder.create(new JsonbConfig().setProperty("johnzon.skip-cdi", true))) { | ||
| final var workDir = Files.createDirectories(Paths.get(workdir)); | ||
| Files.deleteIfExists(Path.of(workDir + "/releases-blog-post.adoc")); |
There was a problem hiding this comment.
is it needed? if you open it without options it will overwrite it anyway at https://github.com/yupiik/tools-maven-plugin/pull/7/files#diff-7a9a6ae89337aab9648e9b123bfc69faa4c9f7f0fc9ee020b1856df90709e6e2R180 no?
There was a problem hiding this comment.
Yes because if you run it several time, it will append so we need to clean up at each run.
There was a problem hiding this comment.
Not really, it does cause you asked to append, if you dont it does not
There was a problem hiding this comment.
We append for each repository, so another option will be to write to the file at the end.
| var out = new StringBuilder(); | ||
|
|
||
| out.append("== ").append(githubRepository.replaceAll("yupiik/", "")).append("\n\n"); | ||
| DateFormat df = new SimpleDateFormat("dd/MM/yyyy"); |
| throw new IllegalStateException(e); | ||
| } | ||
| }); | ||
| try (final var outputStream = Files.newOutputStream(Path.of(workDir + "/releases-blog-post.adoc"), APPEND, CREATE)) { |
fpapon
force-pushed
the
blog-release
branch
3 times, most recently
from
2ea414b
to
ab151f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.