Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency on torch to allow 2-series #52

Conversation

nathanpainchaud
Copy link

Now that PyTorch 2.0 is finally here, it's been confirmed to be 100% backward compatible with version 1.X. Therefore, the version constraint on torch could be relaxed to allow using it with the 2-series.

Now that PyTorch 2.0 is finally here, it's been [confirmed to be 100% backward compatible with version 1.X](https://pytorch.org/get-started/pytorch-2.0/). Therefore, the version constraint on `torch` could be relaxed to allow using it with version 2.X.
@Yura52
Copy link
Collaborator

Yura52 commented Jul 7, 2023

@nathanpainchaud Thank you for the pull request! Currently, the future of this project is uncertain, so I can merge the pull request, but I cannot publish a new version of the package to PyPI. If simply merging the pull request helps you, I can do that.

@nathanpainchaud
Copy link
Author

Hi @Yura52! Thanks for the quick feedback. In my case I don't need to have the PR merged because I've changed my projects to depend on my fork's branch. But I think, even if you can't publish the update to pypi, it would be easier for other users to be able to install from your GitHub repository directly (rather than patch things themselves like I did) if they need to support the PyTorch 2-series.

@Yura52
Copy link
Collaborator

Yura52 commented Jul 7, 2023

I see. I think, for now, I will keep this PR open and, if it receives more attention, I will merge it. Currently, I am not absolutely sure that it will not break anything, because PyTorch 2.0 is rather "mostly backward-compatible", and many projects needed some extra work before supporting the new version.

@Yura52 Yura52 mentioned this pull request Jul 23, 2023
@jerronl
Copy link

jerronl commented Aug 15, 2023

Now that PyTorch 2.0 is finally here, it's been confirmed to be 100% backward compatible with version 1.X. Therefore, the version constraint on torch could be relaxed to allow using it with the 2-series.

How about libzero, which also require torch<2?

@Yura52
Copy link
Collaborator

Yura52 commented Dec 21, 2023

@nathanpainchaud @jerronl Hi! The rtdl package is now replaced with two packages, both of which are compatible with PyTorch 2.0:

@Yura52 Yura52 closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants