Automatic Browser Open #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait for sometime allowing server to run Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
|
@yusukebe can you please take a look |
|
Hi @king-11 Great! One thing. How about adding an option to disable automatic browser opening. Such as |
|
Sounds good to me I will make changes for it |
king-11
force-pushed
the
browser
branch
2 times, most recently
from
2daf007
to
36202f8
Compare
check for disable auto open flag before launching go routine Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
|
@yusukebe I have added in the flag please take a look |
yusukebe
requested changes
Jan 31, 2022
golint needs to check error if any Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
|
@king-11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to open browser automatically.
Fixes #25