Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the max URI length configurable #626

Merged
merged 9 commits into from
Mar 7, 2021
Merged

Make the max URI length configurable #626

merged 9 commits into from
Mar 7, 2021

Conversation

lind
Copy link
Contributor

@lind lind commented Mar 6, 2021

Proposal for #555

@lind lind mentioned this pull request Mar 6, 2021
Closed
@ggrossetie
Copy link
Member

Thanks @lind!
Overall it's looking good, I'm very pleased that you've added tests 👍

I left a few comments, let me know what you think.

lind and others added 2 commits March 6, 2021 19:49
@lind @ggrossetie
Update docs/modules/setup/pages/configuration.adoc
0418c9d 
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
@lind @ggrossetie
Update docs/modules/setup/pages/configuration.adoc
9b91b3a 
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
@ggrossetie
Copy link
Member

Final round and then we are good to go! 🎉

lind and others added 2 commits March 7, 2021 12:38
@lind @ggrossetie
Update docs/modules/setup/pages/configuration.adoc
456126f 
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
@lind @ggrossetie
Update server/src/main/java/io/kroki/server/Server.java
928338d 
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
@ggrossetie ggrossetie changed the title Max uri length Make the max URI length configurable Mar 7, 2021
@ggrossetie ggrossetie merged commit 7c0664e into yuzutech:master Mar 7, 2021
@ggrossetie
Copy link
Member

@lind And merged! Thanks again 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lind @ggrossetie