Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest beta breaks stash #211

Closed
jsbain opened this issue Sep 23, 2016 · 2 comments · Fixed by #314
Closed

latest beta breaks stash #211

jsbain opened this issue Sep 23, 2016 · 2 comments · Fixed by #314

Comments

@jsbain
Copy link
Contributor

jsbain commented Sep 23, 2016

looks like the latest beta:

  1. moved the py2kit framework.
        python_capi = ctypes.PyDLL(
            os.path.join(os.path.dirname(sys.executable),
                         'Frameworks/Py2Kit.framework/Py2Kit')

though we probably want to check in the old place too, for non bet users.
2) _outputcapture is gone...i forget how we found this, need to set a trace somewhere? @dgelessus ?
@jsbain
Copy link
Contributor Author

jsbain commented Sep 23, 2016

#212

@dgelessus
Copy link
Contributor

@jsbain

>>> import sys
>>> import dis
>>> dis.dis(sys.stdin.__class__)

etc.

It looks like the module was just renamed to pykit_io. No other changes that I can see.

@jsbain jsbain mentioned this issue Dec 2, 2016
Closed
bennr01 added a commit to bennr01/stash that referenced this issue May 4, 2018
@bennr01
commit for closing a lot of issues at once
24b67fa 
#About this commit/PR
This is a commit/PR to close a large number of old/fixed issues at once using the github `fix #<issuenumber>` syntax.
Below is a list of all issues which will automatically be closed by merging this commit/PR into `ywangd/master`.
Behind each issue number is a short summary about the issue or why it can be closed.

#Issues which can be closed

**Py3 related:**
- fix ywangd#281 (py3 had not yet been supported)
- fix ywangd#261 (python3 pip installation)
- fix ywangd#246 (python3 code in python2)
- fix ywangd#222 (python3 command in stash)
- fix ywangd#200 (pip now works (at least partially) with python3)
- close ywangd#197 (general pythonista3 compatibility thread)


**Questions which have been answered / unfixable bugs:**
- close ywangd#310 (pip installation with c code)
- close ywangd#292 (StaSh is not dead; also a question regarding py3)
- close ywangd#290 (pip installation, problem solved)
- close ywangd#289 (answer provided, no further activity by reporter)
- close ywangd#279 (pip install protects standard distribution)
- close ywangd#245 (answered)
- close ywangd#244 (not possible (unless someone finds a workaround)
- close ywangd#243 (c-code in pip installation)
- close ywangd#208 (question answered)


**implemented suggestions/changes:**
- fix ywangd#273 (partially implemented as part of py2and3)
- fix ywangd#193 (implemented by now)
- fix ywangd#63  (subcommand completion; implemented long ago)
- fix ywangd#39  (pip; implemented long ago)

**fixed bugs:**
- fix ywangd#308 (https error in pip; fixed)
- fix ywangd#223 (old beta-related bug)
- fix ywangd#211 (old beta-related bug)
- fix ywangd#209 (seems to be fixed, can not reproduce)
- fix ywangd#206 (git did not clone into subdirectory; fixed)
- fix ywangd#98  (telnet did not send \r\n; fixed)


**other stuff:**
- close ywangd#260 (no useful bug description)
- close ywangd#258 (no useful bug description)
- close ywangd#251 (not a bug but an announcement, no longer relevant)
- close ywangd#241 (works now)
- close ywangd#219 (no further acivity by reporter, likely user error)


#Issues which can be closed, but where the underlying issue has not been fixed
- close ywangd#285 (pip command too complex)
- close ywangd#291 (pip installation question, but not c-code related. But seems package-related)
- close ywangd#274 (pip install problem, at least partial related to c-code, no further activity by reporter)
@bennr01 bennr01 mentioned this issue May 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close old/fixed issues bennr01/stash
2 participants
@dgelessus @jsbain