-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cof memory management #320
Improve cof memory management #320
Conversation
Pull Request Test Coverage Report for Build 2063
💛 - Coveralls |
Added descriptions of the 'method' argument.
Thanks for the feedback! I've indeed forgotten to update the documentation properly. The latest commits should solve this. |
Perfect. Quick eyeballing looks good to me and it also satisfies the unit tests. I will merge it for now for some local tests. |
Great! I would certainly appreciate being added to the about page. The info for that would be:
|
Great! Will update the documentation accordingly. |
This PR adds functionality to COF to allow for the selection of one of two methods:
"fast" which will use the old calculation using the full pairwise distance matrix.
"memory" which will use a new method, which only calculates distances when needed, thus saving on memory at the price of speed.
This PR follows up on issue #315
All Submissions Basics:
All Submissions Cores: