-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic histogram size selection #321
Merged
yzhao062
merged 11 commits into
yzhao062:development
from
RoelBouman:automatic_histogram_size_selection
Oct 27, 2021
Merged
Automatic histogram size selection #321
yzhao062
merged 11 commits into
yzhao062:development
from
RoelBouman:automatic_histogram_size_selection
Oct 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea17251.
Undoes inadvertent changes in utility.py
Pull Request Test Coverage Report for Build 2065
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2057
💛 - Coveralls |
LODA test did not properly cover the automatic histogram selection.
Due to the fail of the coveralls check I noted a mistake in one of the newer tests I've written. This should now be fixed. |
This looks great. I will take care of other formatting and documentation thing. Thanks a lot and sorry for being late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new functionality to PyOD by allowing for automatic determination of the optimal number of bins for histograms. This can therefore improve the results from HBOS and LODA.
The PR solves #189
All Submissions Basics:
All Submissions Cores: