Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic histogram size selection #321

Merged

Conversation

RoelBouman
Copy link
Contributor

This PR adds new functionality to PyOD by allowing for automatic determination of the optimal number of bins for histograms. This can therefore improve the results from HBOS and LODA.

The PR solves #189

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

@coveralls
Copy link

coveralls commented Jul 16, 2021

Pull Request Test Coverage Report for Build 2065

  • 194 of 196 (98.98%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 95.923%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/models/loda.py 42 44 95.45%
Files with Coverage Reduction New Missed Lines %
pyod/models/cof.py 1 98.59%
pyod/test/test_cof.py 1 99.4%
Totals Coverage Status
Change from base Build 2052: 0.1%
Covered Lines: 5599
Relevant Lines: 5837

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2057

  • 173 of 196 (88.27%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 95.506%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/models/loda.py 21 44 47.73%
Totals Coverage Status
Change from base Build 2052: -0.3%
Covered Lines: 5483
Relevant Lines: 5741

💛 - Coveralls

Roel added 2 commits July 19, 2021 16:51
LODA test did not properly cover the automatic histogram selection.
@RoelBouman
Copy link
Contributor Author

Due to the fail of the coveralls check I noted a mistake in one of the newer tests I've written. This should now be fixed.
In addition, I've updated HBOS and LODA documentation in this PR to be in line with ABOD and COF.

@yzhao062 yzhao062 merged commit 4264abc into yzhao062:development Oct 27, 2021
@yzhao062
Copy link
Owner

This looks great. I will take care of other formatting and documentation thing. Thanks a lot and sorry for being late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants