Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the std calculation function and the PyODDataset #324

Merged
merged 3 commits into from
Aug 1, 2021
Merged

correct the std calculation function and the PyODDataset #324

merged 3 commits into from
Aug 1, 2021

Conversation

ForestsKing
Copy link
Contributor

@ForestsKing ForestsKing commented Jul 21, 2021

  1. correct the std calculation function before preprocessing
  2. correct the PyODDataset

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

correct the std calculation function before preprocessing
In the original PyODDataset, if preprocessing=false, the error [AttributeError: 'NoneType' object has no attribute 'any'] will be reported.After correction, the problem has been solved.
In the original PyODDataset, if preprocessing=false, the error [AttributeError: 'NoneType' object has no attribute 'any'] will be reported.After correction, the problem has been solved.
@ForestsKing ForestsKing changed the title correct the std calculation function correct the std calculation function and PyODDataset Jul 21, 2021
@coveralls
Copy link

coveralls commented Jul 21, 2021

Pull Request Test Coverage Report for Build 2087

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0007%) to 95.833%

Totals Coverage Status
Change from base Build 2066: -0.0007%
Covered Lines: 5428
Relevant Lines: 5664

💛 - Coveralls

@ForestsKing ForestsKing changed the base branch from master to development July 21, 2021 14:34
@ForestsKing ForestsKing changed the title correct the std calculation function and PyODDataset correct the std calculation function and the PyODDataset Jul 21, 2021
@yzhao062 yzhao062 merged commit 53399bc into yzhao062:development Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants