Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions Basics:
All Submissions Cores:
Hi, this PR addresses the Issue #549
All the previous functionality still exists.
Notable changes include: returned decision scores are no longer normalized, better criterion for switching the scores when necessary, exposing the
decision_function
to correctly handle new data not seen during the OD fitting.Note that the last change above will cause the model to hold more memory as the original dataset must be stored as variable with which to compare the new data to. This will affect a stored joblib model size if created.
If there are any issues let me know and am happy to make the necessary changes.